Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tv_mode.md #26833

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Update tv_mode.md #26833

merged 3 commits into from
Dec 18, 2024

Conversation

estherk15
Copy link
Contributor

What does this PR do? What is the motivation?

  • Add note about readability when optimizing
  • Replace wording suggestion from engineering review

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 requested a review from a team as a code owner December 18, 2024 15:38
@github-actions github-actions bot added the Guide Content impacting a guide label Dec 18, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@janine-c janine-c self-assigned this Dec 18, 2024
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that little typo fix and then we're all good to go!

content/en/dashboards/guide/tv_mode.md Outdated Show resolved Hide resolved
@estherk15 estherk15 requested a review from janine-c December 18, 2024 21:09
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beeeeyooootiful!

@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-18 21:36:09 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2024-12-18 21:41:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bf7933a into master Dec 18, 2024
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the esther/docs-update-tv-mode branch December 18, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants